vp-setupfit error

Created by: RosalynLP

I tried running vp-setupfit on the 9pt theory uncertainties runcard and am getting

[ERROR]: Bad configuration encountered:
A parameter is required: sqrt_covmat.
This is needed to process:
 - nnfit_theory_covmat
through:
 - covs_pt_prescrip
through:
 - combine_by_type
through:
 - each_dataset_results_bytheory
through:
 - results_bytheoryids
through:
 - results

This is a bit concerning because I thought we checked vp-setupfit after the data keyword PR @tgiani. Has anyone else been having problems with vp-setupfit or is this something specific to me?

Created by: siranipour

Ah it could be because sqrt_covmat has been moved to validphys.covmats and we're missing the appropriate import from somewhere

Created by: siranipour

Ah, my bad, when I moved that function I forgot to grep the folders. If you add from validphys.covmats import sqrt_covmat to theorycovariance/construction.py everything should be fixed...

Edit: hmmm or maybe this isn't the issue...

Created by: RosalynLP

No that works for me @siranipour

Created by: voisey

Was this fixed in master?

Created by: RosalynLP

Was this fixed in master?

Nope but I'll fix it now, well spotted :)

Created by: voisey

Cheers!

mentioned in merge request !926 (merged)

Created by: Zaharid

Don't we need to add that module to SETUPFIT_PROVIDERS in validphys2/src/validphys/scripts/vp_setupfit.py?

Created by: siranipour

Oh yes, we do, can you check if that fixes it @RosalynLP? Adding validphys.covmats to https://github.com/NNPDF/nnpdf/blob/2d794c8acd3647c00c5f58d4dbd9add27509588b/validphys2/src/validphys/scripts/vp_setupfit.py#L51 should remove the need for this import

Created by: siranipour

I've gotten confused between the PR and issue...

closed