Allow fitting with perturbative charm (or any other basis)

Created by: scarlehoff

There were a few places where the flavours were fixed (which assumed charm was fitted), this basically propagates the information from the runcard, hoping that at the end it will be rotated to whatever is the correct thing wanted by the fktable.

Two things are missing here,

1. An actual basis (from a quick look, all basis in pdfbases.py are for fitted charm right?, so it needs to be added)
2. An actual check (at the moment I am acting as if the fktables would be just the same meaning that combination 1-2 for theory 53 is the same as for theory 65. Is that the case? (i.e., is any reshuffling of the PDF output needed from one theory to the other?)

In any case, these were the basic points I mentioned in #1002 (closed) blocking the perturbative charm fit from the n3fit side.

n3fit/src/n3fit/checks.py

@@ -311,7 +311,7 @@ def wrapper_hyperopt(hyperopt, hyperscan, fitting, experiments_data):
 
 # Checks on the physics
 @make_argcheck
-def check_consistent_basis(fitting):
+def check_consistent_basis(fitting, theoryid):
     """Checks the fitbasis setup for inconsistencies
     - Correct flavours for the selected basis
     - Correct ranges (min < max) for the small and large-x exponents
@@ -330,5 +330,12 @@ def check_consistent_basis(fitting):
         if name in flavs:
             raise CheckError(f"Repeated flavour name: {name}. Check basis dictionary")
         flavs.append(name)
+    # Finally check whether the basis considers or not charm
     # Check that the basis given in the runcard is one of those defined in validphys.pdfbases
-    check_basis(fitbasis, flavs)
+    basis = check_basis(fitbasis, flavs)["basis"]
+    # Now check that basis and theory id are consistent
+    has_c = basis.has_element("cp") or basis.has_element("T15")
+    if theoryid.get_description()["IC"] and not has_c:
+        raise CheckError(f"{theoryid} (intrinsic charm) is incompatible with basis {fitbasis}")
+    if not theoryid.get_description()["IC"] and has_c:
+        raise CheckError(f"{theoryid} (perturbative charm) is incompatible with basis {fitbasis}")