Skip to content

Remove useless namespaces / change runcard names

Emanuele Roberto Nocera requested to merge remove_useless_namespaces into master

Created by: scarlehoff

In this PR I will try to address #1166 (closed) so that the runcard specification when the code is as sensible as possible.

I was not sure whether it was better to have a different PR for every specific change which would make it easier to review but since the runcards will look differently before and after this PR I think it might be better to have them all in one...

(or all separated but they need to be merged at the same time with potential for out of sync...)

The plan is that after this PR (if) is merged the runcards before and after will be incompatible, which means we 100% want to do this before going public...

I will list here the changes I've implemented. I'll try to separate them in different commits so they can be easily cherry picked

  • poslambda -> maxlambda: this value stopped long ago being the "positivity lambda" to become the "max. positivity lambda" and with the inclusion of integrability not even the "positivity" part is right anymore.
  • Moved tensorboard and save/load outside of the fitting dictionary. Not even sure what I was thinking about when I put them in there. I guess encapsulating the n3fit piece or smt.
  • Moved parameters outside fitting.

Things I'll do between tomorrow and Friday I guess so people can complain beforehand:

  • Put the fitbasis and basis inside the same namespace (I find it annoying that they are two different items) and add the sum_rules also there (and modify the check so that only the right sum rules can be used!) --> this is fitting now.
  • Move genrep outside the fitting dictionary

Feel free to suggest other changes I might have forgotten about (this is the time to do so!)

"hacks" done to keep backwards compatibility will be marked with a #BCH comment.

Note: not fixing the test for now as it requires to take a decision on how hard to break backwards compatibility. Note to self: before merging all the runcards need to be rechecked to ensure they are not out of sync (and that includes the ones in the runcards PR!)

Merge request reports