Skip to content

Utilize stats for predictions or any other PDF product

Created by: scarlehoff

As promised, now all PDFs are essentially the same (you asked for the PDF, you get the full PDF, no tricks) which obviously breaks compatibility with libNNPDF.

As a result everything has to be used through the stats class. I've looked around for instances where the mean was taken manually (for instance in effective exponents) or where the _rawdata of the predictions was being accessed and tried to use error_members or data depending on what the question being asked was.

All test pass, which is good (in some of the intermediate steps the regressions test were broken which mean they were picking up the changes) but this needs to be reviewed with a lot of care. Please have a go at #1501 since this builds on top of that one (both are actually not that much code, they are tricky because they touch basically the core of validphys).

The only thing I'm not sure about is lines like this one in the closure tests:

https://github.com/NNPDF/nnpdf/blob/a692709641866ebe6e8a4e799b468b1a14d34bce/validphys2/src/validphys/closuretest/closure_results.py#L213

Because I thought the _rawdata would be just the error members (being MC pdfs most of the time) but the tests only works with .data (so, including the central replica). I guess either I misunderstood what these functions were doing or there is something wrong somewhere else.

Merge request reports

Loading