Skip to content

Remove additional t0 flags

Emanuele Roberto Nocera requested to merge not0flags into master

Created by: Zaharid

The work on covariance matrices added new flags to control to t0 setting, namely use_t0_sampling and use_t0_fitting. These were undocumented, and caused bugs in validphys since t0pdfset could be set by either of them.

Remove both flags and mandate that the fitting covmat always uses t0 while the sampling covmat never uses it.

This removes some footguns and its backwards compatible.

It has the minor disadvantage that the fitting covmat implicitly requires use_t0=True, which is redundant, but it only really matters in n3fit and we set the flag there anyway.

Merge request reports