Skip to content

Use python `CommonData`

Emanuele Roberto Nocera requested to merge use_only_python_commondata into master

Created by: scarlehoff

There has been a half-finished, half-used python version of the CommonData object for a while https://github.com/NNPDF/nnpdf/blob/9d57bb0df15b7269d00d7d56ad3cba63b966c9b0/validphys2/src/validphys/coredata.py#L202

This PR completes so that it can be used everywhere.

This still doesn't allow to remove libNNPDF because the generation of closure test data is still done from libNNPDF. Is there someone in Cambridge dealing with that at the moment @Zaharid ?

If not I could also have a go at that after this is merged.

Note that I have not attempted to fix any possible design problems there could be with the python version of the CommonData or with how the libNNPDF was used. This is just a conversion so that when we move to the new commondata I only have to port one type of CommonData instead of two.

TODO

  • Check all validphys runcards in the example folder to check that I have not missed some corner action not covered by tests.

Merge request reports