Skip to content

Python closure sampling (with the only python commondata branch)

Emanuele Roberto Nocera requested to merge python_closure_sampling_merged into master

Created by: scarlehoff

Hi @Zaharid @comane

As discussed yesterday during the Code Meeting, I've merged PR #1651 and #1650 so that #1650 can be merged since they are mostly orthogonal as previously mentioned. Indeed, the only difference is the export function that can be simply removed so that it uses the new ones, the relevant commit is https://github.com/NNPDF/nnpdf/pull/1660/commits/cc868fb00786ee70a1c563e015f3bb94fce2012a

I would suggest the write functions are put elsewhere so that circular imports are not generated, but I guess for that you can discuss among yourselves where to put what. With this the two branches should be without conflict.

(unless people requests changes in #1650 of course, but I'm not taking responsibility for that xd)

Merge request reports