Skip to content

New Common Datasets

Emanuele Roberto Nocera requested to merge new_commondata_collected into master

Created by: scarlehoff

This branch/PR will collect all datasets which are fully implemented in the new commondata format.

When you finish a dataset (or group of datasets) please create a PR pointing to this branch. Then the PR will be tested by either @enocera or myself, ensuring that not only the data and uncertainties are correct but also that the validphys plotting works, all necessary variables defined, etc.

Before opening a PR please ensure that:

  1. For all new datasets which have an "old" version, you've added a mapping to buildmaster/dataset_names.yml with NEW_NAME: OLD_NAME.
  2. The plotting, kinematics and theory sections are filled with all the necessary information.
  3. The nnpdf31_process matches whatever was the nnpdf31_process in the old version.
  4. If the new implementation fixes bugs or changes the dataset, include a legacy (or similar) variant in order to reproduce the old results.

(I've update this list with more points that might be important to remember!)

In principle you should be able to use the new commondata reader: https://github.com/NNPDF/nnpdf/pull/1678 to check by yourself that everything is working.

The definition of the new commondata is documented in https://github.com/NNPDF/nnpdf/pull/1708. Please let me know if anything is missing.

In practical terms, you don't need to branch out of this branch. When you are done a think that a dataset is finished, you can either open a PR only with that dataset of with a collection of them and I will deal with the merge. Please don't change files outside of the datasets that you are implementing unless absolutely necessary.

Merge request reports