Skip to content

Fix photon replicas generation + make vp-nextfitruncard use Q0 instead of Qmin for iterating preprocessing

Emanuele Roberto Nocera requested to merge fix_ph into master

Created by: niclaurenti

Opening this PR to fix a bug in the photon sector: in the case of single replica fits, after that the Photon object was computed in

https://github.com/NNPDF/nnpdf/blob/72008b25884f65848fe9741b2842e2bc927638fc/n3fit/src/n3fit/model_trainer.py#L825

it was recomputed in

https://github.com/NNPDF/nnpdf/blob/72008b25884f65848fe9741b2842e2bc927638fc/n3fit/src/n3fit/model_gen.py#L445

with replicas=[1]. Since replicas is a list containing the replicas IDs of the different replicas, it was computing the replica n. 1 for all the replicas (sorry for repeating replicas 5 times in a single sentence). Moreover, the Photon object already contains just one photon in the single replica fits, so there's no need to recompute it imposing just 1 replica.

Merge request reports

Loading