Skip to content

Fix kinematic vs kinematic_coverage check

Emanuele Roberto Nocera requested to merge fix-kinematic-check into master

Created by: Radonirinaunimi

Currently, when kinematic_coverage does not contain 3 variables and len(kinematics.variable)<=3, extra_ variables are added to comply with vp. https://github.com/NNPDF/nnpdf/blob/8b9b29fbbb55a59d6eb2d459307bc30ede977cbb/validphys2/src/validphys/commondataparser.py#L399

This, however, could be inconsistent with the following check: https://github.com/NNPDF/nnpdf/blob/8b9b29fbbb55a59d6eb2d459307bc30ede977cbb/validphys2/src/validphys/commondataparser.py#L435-L439

This is a minimal fix by basically skipping extra_ whenever kinematics and kinematic_coverage are compared.

Merge request reports