Skip to content

Adding data keyword to validphys

Emanuele Roberto Nocera requested to merge add-data-kw into master

Created by: wilsonmr

Adding the data keyword to validphys, supersedes #515

the idea here is discussed at length in PR #515 but the idea is to have a flat input of datasets rather than introduce experiment hierarchy at the level of the runcard - instead arbitrary groupings can be done with meta data or whatever

defaults will be filled in - waiting on lockfiles for this

we think that the current implementation is fully backwards compatible - all actions will now depend on data and all fits which do not have a data key are given one in as_input from their experiment specification. Then just need to be careful to make sure that action dependencies are all sorted out correctly

To do:

  • parsing data from runcard as some simple object (list of dataset_inputs)
  • produce data which is more complicated object - currently abusing ExperimentSpec
  • add backwards compatibility at the level of FitSpec
  • interface with lockfile/defaults when available so user can just input list of dataset names
  • sensible way to group data in various ways
  • check we didn't break anything

Merge request reports