total chi2/phi use experiments

Created by: wilsonmr

provided no theory covmat is being used. I don't see an imminent issue with this and it significantly speeds up comp fits

@tgiani please can you run a compfits using this and check the numbers are the same in particular in the fit summary table and the total row of the chi2 table?

Note I also changed the provider name for some plot functions which I guess we never use because the providers were non-existent before. Hopefully they work now.

Finally I also added a small fix for a bug I guess was introduced in #862 where a function relied on an import of linalg but the import didn't exist @RosalynLP can you check you agree with that? (EDIT: specifically in results.py with experiments_invcovmat)

closes #860 (closed) closes #924 (closed)

requested review from @enocera

requested review from @enocera

Created by: tgiani

@wilsonmr yep, I ll do today

mentioned in merge request !929 (merged)

Created by: tgiani

ok so we have a winner:

• old branch before the data key word: 11min 32sec
• this branch: 12min 19sec

sorry Mike, good effort though. The reports look fine, it looks to me that the numbers are the same. I m uploading them anyway, I ll link them here

Created by: tgiani

https://vp.nnpdf.science/MKtBq8knRY-pWtkm3Hnarw== https://vp.nnpdf.science/Dv2N1mngQFqcbqUIY3B6FA==

Created by: wilsonmr

looks good to me!

Created by: RosalynLP

Yep thanks for fixing the bug, looks good

Created by: tgiani

Review: Approved

looks good thanks!

Created by: Zaharid

Why the import?

Created by: wilsonmr

Finally I also added a small fix for a bug I guess was introduced in #862 where a function relied on an import of linalg but the import didn't exist @RosalynLP can you check you agree with that? (EDIT: specifically in results.py with experiments_invcovmat)

something slipped through the net on previous PR

Merged by: scarrazza at 2020-09-23 14:20:04 UTC

merged manually

closed

mentioned in issue #752 (closed)

mentioned in merge request !1005 (merged)