Skip to content
Snippets Groups Projects
Commit 728a2232 authored by Radonirinaunimi's avatar Radonirinaunimi
Browse files

fix inconsistent check between kinematic and kinematic_coverage

parent 8b9b29fb
No related branches found
No related tags found
1 merge request!2023Fix kinematic vs kinematic_coverage check
......@@ -433,9 +433,9 @@ class ObservableMetaData:
# Ensure that all variables in the kinematic coverage exist
for var in self.kinematic_coverage:
if var not in self.kinematics.variables:
if var not in self.kinematics.variables and not var.startswith("extra_"):
raise ValidationError(
f"Variable {var} is in `kinematic_coverage` but not included in `kinematics` for {self.name}"
f"Variable {var} is in `kinematic_coverage` but not included in `kinematics` nor part as `extra_` for {self.name}"
)
if len(self.kinematic_coverage) > 3:
......
......@@ -85,6 +85,7 @@ class _Process:
if kin_cov == ["k1", "k2", "k3"]:
return True
# We check if kin_cov is a subset of self.accepted_variables
kin_cov = [v for v in kin_cov if not v.startswith("extra_")]
return set(self.accepted_variables).union(set(kin_cov)) == set(self.accepted_variables)
def xq2map(self, kin_df, metadata):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment