Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
N
nnpdf
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Emanuele Roberto Nocera
nnpdf
Commits
728a2232
Commit
728a2232
authored
1 year ago
by
Radonirinaunimi
Browse files
Options
Downloads
Patches
Plain Diff
fix inconsistent check between kinematic and kinematic_coverage
parent
8b9b29fb
No related branches found
Branches containing commit
No related tags found
1 merge request
!2023
Fix kinematic vs kinematic_coverage check
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
validphys2/src/validphys/commondataparser.py
+2
-2
2 additions, 2 deletions
validphys2/src/validphys/commondataparser.py
validphys2/src/validphys/process_options.py
+1
-0
1 addition, 0 deletions
validphys2/src/validphys/process_options.py
with
3 additions
and
2 deletions
validphys2/src/validphys/commondataparser.py
+
2
−
2
View file @
728a2232
...
...
@@ -433,9 +433,9 @@ class ObservableMetaData:
# Ensure that all variables in the kinematic coverage exist
for
var
in
self
.
kinematic_coverage
:
if
var
not
in
self
.
kinematics
.
variables
:
if
var
not
in
self
.
kinematics
.
variables
and
not
var
.
startswith
(
"
extra_
"
)
:
raise
ValidationError
(
f
"
Variable
{
var
}
is in `kinematic_coverage` but not included in `kinematics` for
{
self
.
name
}
"
f
"
Variable
{
var
}
is in `kinematic_coverage` but not included in `kinematics`
nor part as `extra_`
for
{
self
.
name
}
"
)
if
len
(
self
.
kinematic_coverage
)
>
3
:
...
...
This diff is collapsed.
Click to expand it.
validphys2/src/validphys/process_options.py
+
1
−
0
View file @
728a2232
...
...
@@ -85,6 +85,7 @@ class _Process:
if
kin_cov
==
[
"
k1
"
,
"
k2
"
,
"
k3
"
]:
return
True
# We check if kin_cov is a subset of self.accepted_variables
kin_cov
=
[
v
for
v
in
kin_cov
if
not
v
.
startswith
(
"
extra_
"
)]
return
set
(
self
.
accepted_variables
).
union
(
set
(
kin_cov
))
==
set
(
self
.
accepted_variables
)
def
xq2map
(
self
,
kin_df
,
metadata
):
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment